Skip to content

Add BAIS2 UDP entry for Development Seed#316

Closed
zacdezgeo wants to merge 9 commits intoESA-APEx:mainfrom
developmentseed:alg/bais2
Closed

Add BAIS2 UDP entry for Development Seed#316
zacdezgeo wants to merge 9 commits intoESA-APEx:mainfrom
developmentseed:alg/bais2

Conversation

@zacdezgeo
Copy link
Copy Markdown
Contributor

Create provider record, add BAIS2 service record and UDP JSON, and include preview/thumbnail images from the notebook output.

@zacdezgeo zacdezgeo marked this pull request as draft January 21, 2026 11:40
@HansVRP HansVRP requested a review from JanssenBrm January 27, 2026 14:56
Create provider record, add BAIS2 service record and UDP JSON, and include preview/thumbnail images from the notebook output.
@zacdezgeo zacdezgeo marked this pull request as ready for review January 28, 2026 11:24
@zacdezgeo zacdezgeo marked this pull request as draft January 28, 2026 11:27
@zacdezgeo zacdezgeo marked this pull request as ready for review January 29, 2026 07:25
Comment thread algorithm_catalog/developmentseed/record.json
Comment thread algorithm_catalog/developmentseed/record.json Outdated
Comment thread algorithm_catalog/developmentseed/record.json Outdated
Comment thread algorithm_catalog/developmentseed/record.json
Comment thread algorithm_catalog/developmentseed/bais2/records/bais2.json
Comment thread algorithm_catalog/developmentseed/bais2/records/bais2.json
Comment thread algorithm_catalog/developmentseed/bais2/records/bais2.json Outdated
Comment thread algorithm_catalog/developmentseed/bais2/records/bais2.json
@JanssenBrm
Copy link
Copy Markdown
Contributor

Thank you @zacdezgeo for this initial PR and setting up the records. My apologies for the many comments, but it seems that the records are still requiring some information to pass the unit test.

I see that our documentation is missing a part where you can execute the unit tests locally, but I did this by following these steps:

  1. Installing the APEx QA tooling by running pip install qa/tools
  2. Executing the validation of the records through pytest qa/unittests/tests/test_records.py

I would expect the unit tests to be running from the PR automatically, but it seems that they are not getting started...

Unfortunately, there is also a known bug where the preview function of the catalogue is not working from remote forks. However, I suggest that once the records have been updated, we duplicate the branch to this repository, allowing you to visually inspect how the record would look like in the catalogue.

Add TiTiler openEO platform record and link BAIS2
@zacdezgeo
Copy link
Copy Markdown
Contributor Author

Thank you so much for the detailed review and for taking the time to leave all of these comments. I really appreciate it.

This is my first contribution to the apex_algorithms repository, and your feedback is extremely helpful for understanding the expected schema requirements (especially around provider metadata and link conventions). It’s been a great guide for getting the records into the shape needed to pass the unit tests and display correctly in the catalogue.

I’ll work through the requested updates and rerun the QA validation locally with pytest qa/unittests/tests/test_records.py before pushing the next commit.

Thanks again for the support in navigating the contribution process here, it’s very appreciated.

@zacdezgeo zacdezgeo marked this pull request as draft January 29, 2026 16:11
@zacdezgeo
Copy link
Copy Markdown
Contributor Author

I followed up on your comments regarding the record's links, but I still need to add the platform's logo (dark and light) based on the results from running: pytest qa/unittests/tests/test_records.py. I'll follow-up.

@zacdezgeo zacdezgeo marked this pull request as ready for review February 7, 2026 14:41
@zacdezgeo zacdezgeo requested a review from JanssenBrm February 17, 2026 13:45
@JanssenBrm
Copy link
Copy Markdown
Contributor

Thank you very much for the updates @zacdezgeo and my apologies for the delayed review. Everything looks good now, if you can just update the branch to be up-to-date with the latest changes, I can merge it to the main branch so that you can see the resulting service.

@zacdezgeo
Copy link
Copy Markdown
Contributor Author

@JanssenBrm ; just updated! let me know if there's any next steps i can look into

@JanssenBrm JanssenBrm mentioned this pull request Mar 4, 2026
@JanssenBrm
Copy link
Copy Markdown
Contributor

Thank you @zacdezgeo, for the last updates. As the preview feature is not working from a remote fork, due to privileges, I have merged your changes into a new PR: #378. I'm going to close this one so that we can finalize everything in the other PR.

@JanssenBrm JanssenBrm closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants