Skip to content

Avoid stalling in HighsRedcostFixing::addRootRedcost - #3241

Merged
Opt-Mucca merged 5 commits into
ERGO-Code:latestfrom
fwesselm:stallFindLurkingBounds
Aug 27, 2026
Merged

Avoid stalling in HighsRedcostFixing::addRootRedcost#3241
Opt-Mucca merged 5 commits into
ERGO-Code:latestfrom
fwesselm:stallFindLurkingBounds

Conversation

@fwesselm

@fwesselm fwesselm commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Avoid stalling in HighsRedcostFixing::addRootRedcost for huge bounds (>= kHighsIInf) on integer variables.
  • Add a unit test.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@fwesselm
fwesselm requested review from Opt-Mucca and jajhall August 27, 2026 08:29
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (d7c50d1) to head (5b23b52).
⚠️ Report is 8 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3241   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files         445      445           
  Lines      108019   108070   +51     
  Branches    17318    17321    +3     
=======================================
+ Hits        79106    79150   +44     
- Misses      28637    28644    +7     
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall

jajhall commented Aug 27, 2026

Copy link
Copy Markdown
Member

I'll still add the code to transform bounds greater than or equal to kHighsIInf on integer variables to kHighsInf.

However, if someone gives an integer variable a bound of kHighsIInf-1, bound modifications in presolve could still lead to integer variables with a bound greater than kHighsIInf, so the safeguard in this PR is wise.

@fwesselm

fwesselm commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

I'll still add the code to transform bounds greater than or equal to kHighsIInf on integer variables to kHighsInf.

However, if someone gives an integer variable a bound of kHighsIInf-1, bound modifications in presolve could still lead to integer variables with a bound greater than kHighsIInf, so the safeguard in this PR is wise.

I am going to push some more code changes to this PR to handle overflows if one or both bounds are extreme (e.g., kHighsIInf - 1).

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong support for the change!

@Opt-Mucca
Opt-Mucca merged commit f8a0595 into ERGO-Code:latest Aug 27, 2026
369 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants