Skip to content

A minor change to HighsSymmetry#3032

Open
fwesselm wants to merge 7 commits into
ERGO-Code:latestfrom
fwesselm:symmetryChanges
Open

A minor change to HighsSymmetry#3032
fwesselm wants to merge 7 commits into
ERGO-Code:latestfrom
fwesselm:symmetryChanges

Conversation

@fwesselm
Copy link
Copy Markdown
Collaborator

@Opt-Mucca, while checking the symmetry detection code, I realized that introducing an enum for the values of rowIsSetPacking may simplify the code a little. I hope you agree.

enum RowPackingStatus : int8_t {
    kRowUndetermined = -1,
    kRowNotPacking = 0,
    kRowPacking = 1,
    kRowPackingNegated = 2,
  };

@fwesselm fwesselm requested a review from Opt-Mucca May 19, 2026 17:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (0e8db55) to head (2f0a20e).
⚠️ Report is 30 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HighsSymmetry.cpp 0.00% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3032   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files         417      417           
  Lines      102156   102151    -5     
  Branches    16467    16463    -4     
=======================================
+ Hits        74374    74375    +1     
+ Misses      27506    27500    -6     
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Opt-Mucca Opt-Mucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredibly strong agree on this being more readable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants