Updated third party dependency support#3031
Open
mathgeekcoder wants to merge 20 commits into
Open
Conversation
…s change is to make dependencies more explicit and provide the consumer with detailed information. Also, to make it easier for us to add new dependencies in the future. * highs_extras is now always built, but with optional features (like HIPO) * Each project (app, libhighs, high_extras) has a file that defines its dependencies * Added --notice to app that prints list of dependencies and their version/license info * Moved all dependencies into extern directory * Refactored FindHipoDeps into cmake functions * Refactored highs_extras CMakeLists, for easier maintenance * Improved naming to closer align to HiGHS standards * Added HighsDynamicLibrary for portable dynamic library loading. Can also be used for future CUDA support via Driver API * Added simple string join and table rendering * Added README documentation for the new features/structure
… type deduction) Fixed BUILD_OPENBLAS issue not identifying version/license information
…ass member initializers
…n order Fixed include issues with HighsDynamicLibrary
…arty methods (even when not used). Also fixed minor meson build error.
… clang and HIPO=OFF. Basically, even though the external methods were never used the debug build still wanted to link to them. So now, we explicitly separate the interface definition and the binding step. Slight code redundancy, but seems unavoidable. Also fixed code coverage workflow with corrected extern paths.
…de/HiGHS into third-party-dependencies
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## latest #3031 +/- ##
==========================================
+ Coverage 72.81% 72.94% +0.13%
==========================================
Files 417 425 +8
Lines 102150 102181 +31
Branches 16463 16443 -20
==========================================
+ Hits 74378 74535 +157
+ Misses 27496 27370 -126
Partials 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@galabovaa and @filikat - I'd appreciate if you could have a look! Apologies, it turned out to be a much larger change than I originally intended. Happy to discuss. |
Significantly improve macos build times (i.e., github actions)
Contributor
I have had a look, and did not spot anything I would disagree with. Thank you again for this! |
Collaborator
|
The details are well beyond what I can comfortably understand in cpp, but it looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to improve external dependency support in HiGHS.
isAvailable<Feature1, Feature2>()supporthipo = require<amd, blas, ...>isAvailable<hipo, require<require<...>, ...>app,libhighs, orhighs_extras, but still use the same APIhighs_extrasAPI, so that adding new features is easier and more consistentgetThirdPartyNotice()and--noticeto get current list of enabled dependencies (with version and license info)HighsDynamicLibrary, which can be used in the near future for dynamic CUDA supportblascmake routines andhighs_extrascmake for increased maintainabilityREADME.mdwith details on how to add new dependencies and how the system worksExample of output: