-
Notifications
You must be signed in to change notification settings - Fork 275
Refacto C# interface #2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Refacto C# interface #2714
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
==========================================
- Coverage 81.06% 81.06% -0.01%
==========================================
Files 347 347
Lines 85219 85219
==========================================
- Hits 69085 69083 -2
- Misses 16134 16136 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I can well believe that the C# API would benefit from refactoring, as I think it just grew from a simple proof-of-concept wrapper around the C API, and we lack the C# expertise to rework it ourselves. However, breaking the old C# API between major versions is unwelcome, and @galabovaa will have to consider the implications for the Nuget build. We only use master for releases, with development pushes being made to latest. |
|
I see. If you prefer the new code organization but don't want to break compatibility, I can rename the items as they were. |
In this Pull Request, I present a proposal for refactoring the C# interface.
Positive points:
Negative points:
If you think it's a good modification, I can help with NuGet. Or with another refactoring proposal.
Generally, if you're looking to make changes or tests to the C# interface, I'm open to helping.