Repository navigation
Conversation
Background image gains a Picture scope: the terminal's column, the default, or the window below the title bar. Settings › Appearance shows the choice beside the image. The picture paints behind the workspace from src/workspace/wallpaper.rs, over the window's ground — the theme's background at the background opacity — so the columns can leave their glass at 0 while a picture is set, and the picture keeps its colors. A canvas ruler records the terminal body's bounds, since a column's header may hold it wider than its width setting, and asks for another frame when they move; the window's picture starts below the title bar from those bounds. The old TerminalView backdrop is gone. settings.json gains background_scope (terminal or window); a file without it keeps the terminal. Tests cover the default and round trip, and both boxes. PRD, AGENTS.md, tasks/acceptance.md and the feature docs say so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
What and why
Background image used to paint only inside the terminal column. This adds a Picture scope — the terminal's column (default) or the window below the title bar — and moves the picture behind the workspace, so it can lie under the whole window. It is the first of the background customization's reviewable PRs.
background_scopejoinsbackground_imagein settings.json:terminalorwindow; a file without it keeps the terminal, so existing settings load unchanged.src/workspace/wallpaper.rspaints the window's ground (the theme's background at the background opacity) and the picture over it at the scope's box. A canvas ruler in the terminal column records the body's real bounds — a column's header may hold it wider than its width setting — and asks for another frame when they move; the window's picture starts at the body's top.src/app.rsre-dresses the chrome when the picture comes or goes.TerminalViewbackdrop andsrc/term/backdrop.rsare gone.How it was tested
cargo fmt --all --checkclean.cargo clippy --all-targets -- -D warningsclean.settings::tests::a_picture_lies_under_the_terminal_unless_the_window_is_chosen,workspace::wallpaper::tests::the_terminal_scope_paints_the_terminal_body,workspace::wallpaper::tests::the_window_scope_starts_below_the_title_bar_and_spans_the_window.cargo test: 410 passed, 8 failed — the failures areterm::shell::windows_tests::*,term::pty::through_conpty::*,term::herdr::tests::herdr_answers_over_its_pipeandexplorer::tests::the_menu_is_added_read_and_removed_under_its_classes, which spawn real shells through ConPTY and write the registry; the sandbox this was built in denies both (exit code 0xc0000142,no folder within 30 seconds). None touches this change; please re-run them in a normal session."background_scope": "terminal"and"window": the picture covered the terminal column, then the whole window below the title bar, with the columns transparent over it and the title bar on the ground (screenshots below).Screenshots
Checklist
[FEATURE REQUEST],[BUG REPORT]or[Other]