Skip to content

[FEATURE REQUEST] Underline terminal links on mouse hover - #61

Open
Chino456 wants to merge 1 commit into
ELY-Open-Source:mainfrom
Chino456:main
Open

Chino456 wants to merge 1 commit into
ELY-Open-Source:mainfrom
Chino456:main

Conversation

@Chino456

@Chino456 Chino456 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Type

  • [FEATURE REQUEST]: a new feature or an improvement
  • [BUG REPORT]: a bug fix
  • [Other]: docs, refactoring, CI, dependencies or chores

What and why

Underline links when the mouse hovers over them, making clickable links easier to discover. Supports plain-text URLs and OSC 8 links, including wrapped links, while preserving existing terminal underline styles and Ctrl/Cmd-click behavior.

OSC 8 hover searches stay within the viewport. Plain-text URL detection uses a 4096-cell / 16 KiB budget and matching delimiters to avoid scanning large history regions or rejecting short URLs beside long JSON fields.

How it was tested

  • cargo test --release --locked --lib --quiet — 429 tests passed.
  • cargo clippy --release --locked --all-targets -- -D warnings — passed.
  • cargo fmt --check — passed.
  • git diff --check — passed.
  • Regression coverage includes wrapped URLs, wide characters, combining marks, OSC 8 viewport boundaries, long logical lines, compact JSON, and hover-style restoration.
  • Final executable rebuild was blocked because the running application held elyterminal.exe open.
  • Manual mouse-hover verification remains pending.

Checklist

  • The title starts with [FEATURE REQUEST], [BUG REPORT] or [Other]
  • Tests and the build pass locally
  • Docs are updated if behaviour changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant