Skip to content

We need sanity-checking CI on PRs #1794

Open

Description

@ocaisa

As the number of open PRs starts to grow, we need to add sanity checks on PRs to verify that every software they claim to add is actually added by the PR (seen in #1771 (comment) for example).

This is complicated to check, as you need to check

  • what is added by the tarballs, is it consistent across architecture families
  • does what is added match the additions to the easystacks
  • check that what is being added by the tarballs does not already exist in the repository (this could be triggered once the deploy label is set, but only once as once ingestion has actually happened this check will fail...so maybe it needs triggering on ready-to-deploy? Special CI for ready-to-deploy sounds a lot like what @casparvl has been working on)

Activity

  1. casparvl commented on Oct 20, 2026

    @casparvl
    Collaborator

    Can you elaborate on what exactly you want to check? I mean, CI cannot really check for tarball contents. At best, it can check for what the bot reports.

    Note that that's what #1564 aims to do: basically automating the assesment of the bot:status last_build report. Nothing more, nothing less.

    I guess you could create an equivalent CI that checks the individual "Success" reports from the bot:build commands to see what they (reportedly) build... But while you can check the eaysconfigs directly listed in the easystack quite easily, all of the dependencies are not know just by reading the PR content - you'd have to actually invoke EasyBuild to resolve that.

  2. ocaisa commented on Oct 20, 2026

    @ocaisa
    MemberAuthor

    CI can check tarball contents to the extent that they are listed in the message posted by the bot, that's indeed what I meant.

    You can easily check what the PR would build by running an eb --missing ... and parsing the output a bit, the plan would be to sanity check that against what the bot is reporting in the comments. Triggering this on ready-to-deploy seems like a good move, as this is the only time you can at least hope that another PR is not going to interfere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions