Only use JSON-native types with sidekiq#461
Draft
adamruzicka wants to merge 2 commits intoDynflow:masterfrom
Draft
Only use JSON-native types with sidekiq#461adamruzicka wants to merge 2 commits intoDynflow:masterfrom
adamruzicka wants to merge 2 commits intoDynflow:masterfrom
Conversation
Contributor
Author
|
Let's see what the tests think |
This has two effects - it casts the input to only contain JSON-native objects and removes amiguity on the receiving end. With the previous implementation, we couldn't reliably distinguish whether what we're accessing was previously dumped into a json by dynflow or if it is a user-provided json-encoded string.
adamruzicka
force-pushed
the
sidekiq-json
branch
from
1e2c655 to
a043bca
Compare
|
Probably needs a rebase, although the tests are green. Can we run this PR against some real scenarios? I mean, to run these changes against foreman-tasks and/or Katello?.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.