Abstract-class reorganization and miscellaneous fixes#16
Merged
Conversation
…nto new abstract class
…multiblock part backgrounds
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this patch to the best of my ability, but I am definitely struggling with testing minecraft mods, so I am looking for help with testing before merge. The changed-files count in Github is inflated from generated classes being removed from Git. Note: I am dipolecat on the Discord
#15 and #14 both focus on bugs fixed by this patch. #14 also suggests naming changes which I consider reasonable, but did not include in my patch because I tried to limit name-changing since that was not discussed.
This patch conflicts with #10. If the changes in #10 are desired, I will volunteer to help resolve those conflicts
Changes:
New features:
Bugfixes:
Performance:
Other: