Skip to content

Abstract-class reorganization and miscellaneous fixes#16

Merged
DutchTristan merged 16 commits into
DutchTristan:mainfrom
tgiddings:carry_out_timing
May 8, 2025
Merged

Abstract-class reorganization and miscellaneous fixes#16
DutchTristan merged 16 commits into
DutchTristan:mainfrom
tgiddings:carry_out_timing

Conversation

@tgiddings
Copy link
Copy Markdown
Contributor

@tgiddings tgiddings commented Mar 10, 2025

I have tested this patch to the best of my ability, but I am definitely struggling with testing minecraft mods, so I am looking for help with testing before merge. The changed-files count in Github is inflated from generated classes being removed from Git. Note: I am dipolecat on the Discord

#15 and #14 both focus on bugs fixed by this patch. #14 also suggests naming changes which I consider reasonable, but did not include in my patch because I tried to limit name-changing since that was not discussed.

This patch conflicts with #10. If the changes in #10 are desired, I will volunteer to help resolve those conflicts

Changes:

  • JK latch only toggles when inputs rise simultaneously

New features:

  • Adder blocks can be mirrored with right click

Bugfixes:

  • fixed Adder carry out being instant
  • fixed Adder input states not being set correctly when placed in some orientations
  • fixed gate timing on placement being inconsistent depending on redstone dust direction
  • fixed regression redstone inputs getting stuck on omnidirectional bridge
  • fixed 2-way bridge's old output strong power not updating when mirroring
  • fixed memory cell not dropping when broken
  • fixed "signal strength of omnidirectional bridge is not decremented when signal is input by redstone dust"
  • fixed "Breaking multiblocks does not update all adjacent redstone dust"
  • fixed "Switches detect 0 tick pulses"
  • fixed strong-powered outputs not updating when default-on gates are placed
  • fixed strong-powered outputs not updating when logic blocks are broken
  • fixed XOR gate sometimes pulsing when both inputs turn on or turn off simultaneously

Performance:

  • reduced extraneous neighbor updates

Other:

  • reorganized abstract classes for logic blocks to not conflict with multiblocks and to be simpler for common use cases
  • use one class for both adder types
  • move adder-specific types and properties into adder class
  • half adder and full adder share some textures for "bottom" part
  • generated classes are no longer tracked
  • removed unused "facing" property from omnidirectional bridge
  • gradle build task now depends on runDatagen task
  • bump mod version (I thought the PR named "1.3.3 patch" already did this, but Github says it's a change in this PR)
  • added a tileset derived from the logic plate texture, which is intended to be used for the backgrounds of multiblock parts

@DutchTristan DutchTristan merged commit 89e49ab into DutchTristan:main May 8, 2025
@MMT007 MMT007 mentioned this pull request May 8, 2025
@tgiddings tgiddings deleted the carry_out_timing branch June 16, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants