Add Linux SSH auditor, simplify SSL HTML title, and update tests/README#1
Merged
Merged
Conversation
Decdd19
pushed a commit
that referenced
this pull request
Apr 17, 2026
CRITICAL
- AccessDenied = secure anti-pattern: s3, cloudtrail, ec2 now return None
sentinel on ClientError; analyse_* functions emit UNKNOWN flags;
report_utils.client_error_unknown_flag() helper added
- IAM self-account false positives: analyse_role(own_account=) param added;
ARN account extracted and compared in run()
- add_auditor.py Linux/generic stub templates: brace-escaped {{ / }}
- CloudTrail public-bucket false negative: covered by CRITICAL #1
HIGH
- Standardise entry-point to run(): guardduty, lambda, linux_firewall,
linux_user renamed; tests updated
- 25 new unit tests: UNKNOWN sentinel behaviour for s3, cloudtrail, ec2,
iam, add_auditor
- ThrottlingException: config_auditor appends UNKNOWN finding per-region
- KMS double-describe_key: analyse_key(meta=) param; run() passes cached meta
- RDS N+1 snapshots: _is_snapshot_public + ThreadPoolExecutor(min(10,N))
- Module-load NOW: email_security_auditor computes NOW inside run()
MEDIUM
- linux_firewall_auditor: iptables -L -n -v + field-position parsing
- linux_patch_auditor: zypper sec_count uses prefix-match, no header hack
- linux_ssh_auditor: html_out rename (html module unshadowed); SSH auditor
emits overall_risk=UNKNOWN when >50% checks are N/A
- linux_user_auditor: lastlog called once via _load_lastlog_table()
- securityhub_auditor: div.header brand wrapper; .val→.num; get_styles()
- http_headers_auditor: CSP warns on wildcard default-src and missing
frame-ancestors; re import added
- exec_summary: SSH UNKNOWN special-case removed; UNKNOWN honoured via
general summary_risk path
- audit.py + exec_summary.py: @@AUDITOR_MAP_END@@ and
@@KNOWN_PATTERNS_END@@ marker comments for add_auditor.py
- add_auditor.py: marker-based insertion replaces fragile regex
Tests: 983 passed, 1 skipped
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
<title>generation inNetwork/ssl-tls-auditor/ssl_tls_auditor.pyby introducingclient_title_suffixand using a single formatted title string with an em-dash separator.audit.pyto reflect five Linux auditors (added--linux_sshto the displayed list).tests/test_audit.pyto expect 5 Linux auditors and renamed the test totest_linux_selects_exactly_5.Local test setupsection toREADME.mdwith a samplepip installandpytestcommand for running tests locally.Testing
tests/(viapytest tests/) and the updatedTestSelectAuditorstests passed, includingtest_linux_selects_exactly_5.Codex Task