Add collection return support to ScanForTypes attribute#55
Draft
Add collection return support to ScanForTypes attribute#55
Conversation
…ble<T>) Co-authored-by: Dreamescaper <17177729+Dreamescaper@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Return found types as an array implementation
Add collection return support to ScanForTypes attribute
Mar 20, 2026
| : GenerateCustomHandlingSource(method, customHandling); | ||
| : method.ReturnTypeIsCollection | ||
| ? GenerateCollectionSource(method, collectionItems) | ||
| : GenerateCustomHandlingSource(method, customHandling); |
Owner
There was a problem hiding this comment.
replace nester ternary with switch expression
| typesFound = true; | ||
|
|
||
| if (attribute.CustomHandler != null) | ||
| var implementationTypeName = implementationType.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat); |
Owner
There was a problem hiding this comment.
split extract collection handling and custom handler to private methods
| { | ||
| public static partial global::System.Type[] GetServiceTypes() | ||
| { | ||
| return [typeof(global::GeneratorTests.MyService1), typeof(global::GeneratorTests.MyService2)]; |
Owner
There was a problem hiding this comment.
Update to use multiline collection expression, e.g.
public static partial global::System.Type[] GetServiceTypes()
{
return [
typeof(global::GeneratorTests.MyService1),
typeof(global::GeneratorTests.MyService2)
];
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScanForTypesmethods can now returnType[]orIEnumerable<Type>(no Handler needed) to get the matched types directly, or returnTResponse[]/IEnumerable<TResponse>when a Handler mappingT → TResponseis provided. This feature is exclusive toScanForTypes;GenerateServiceRegistrationsis unaffected.New capabilities
Changes
MethodModel— addedReturnTypeIsCollection/CollectionElementTypeNamefields and aGetCollectionReturnInfo()helper that detects array andIEnumerable<T>return types usingSpecialType.System_Collections_Generic_IEnumerable_T.MethodImplementationModel— addedCollectionItems(EquatableArray<string>) holding the pre-built expression strings for each collection element.ParseHandlerMethodModel— relaxes the "Handler required" rule when the return type isType[]/IEnumerable<Type>; validates Handler return type matches the collection element type for mapped returns.FindServicesToRegister— populatesCollectionItemswithtypeof(T)expressions (no-Handler path) or handler invocation expressions (Handler path).DependencyInjectionGenerator— addsGenerateCollectionSource()emitting a C# collection expression (return [...]); routes generation accordingly.DiagnosticDescriptors— new diagnosticDI0015(WrongHandlerReturnTypeForCollectionReturn) when the Handler's return type doesn't match the collection element type.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.