feat: zoom waveform with [/], fit view with F#908
Open
vowstar wants to merge 1 commit into
Open
Conversation
Match EDA convention (GTKWave, ModelSim, Virtuoso): F for "Zoom Full"; ]/[ for zoom in/out, mirroring the image-editor convention (Photoshop, Krita). Existing Left/Right arrow zoom is preserved. The F handler explicitly resets offset to 0 because View::auto_set_max_scale() only sets scale and leaves offset at wherever the user had scrolled to. Signed-off-by: Huang Rui <vowstar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
]and[for zoom in/out andFto fit the whole capture in view. Same as GTKWave and Cadence Virtuoso.Arrow keys still zoom, but plenty of keyboards have no dedicated arrow row (60%, HHKB, etc.) so it's always an Fn chord. Also awkward when one hand is on the mouse. Brackets and F sit next to the home row.