-
Notifications
You must be signed in to change notification settings - Fork 513
Update tests for new line pragma format in C# 10 #4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
========================================
Coverage 97.48% 97.49%
========================================
Files 1019 1037 +18
Lines 118618 119302 +684
Branches 3465 3475 +10
========================================
+ Hits 115633 116309 +676
- Misses 1976 1989 +13
+ Partials 1009 1004 -5 🚀 New features to boost your workflow:
|
|
Marked as draft because this one will need additional tests for spacing around parentheses, commas, and the It looks like the VS formatter doesn't adjust anything inside a #line (1, 1) - (5, 60) 10 "partial-class.cs"@CyrusNajmabadi can you confirm if the formatting here would be considered the canonical formatting for this feature, such that if Format Document started adjusting it, this is the form it would produce? |
|
I'm fine with either that, or the following: #line (1, 1)-(5, 60) 10 "partial-class.cs"I personally prefer the latter as it 'binds' the start-end parts tightly to eachother. Whereas the "spaces around minus" approach makes it less clear what is happening. I do not feel strongly though, and am fine with either. |
Closes #3992