Skip to content

fix/docker-context-path-default: Placeholder with name attribute "doc… - #5231

Open
drago1520 wants to merge 1 commit into
Dokploy:canaryfrom
drago1520:fix/docker-context-path-default
Open

fix/docker-context-path-default: Placeholder with name attribute "doc…#5231
drago1520 wants to merge 1 commit into
Dokploy:canaryfrom
drago1520:fix/docker-context-path-default

Conversation

@drago1520

@drago1520 drago1520 commented Aug 31, 2026

Copy link
Copy Markdown

…kerContextPath" lied that the default path is ".", while being the Dockerfile directory.

What is this PR about?

Docker context path input UI lies.

Please describe in a short paragraph what this PR is about.
image
while it's actually the Dockerfile directory as context by default.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

Screenshots (if applicable)

It's my first PR here :)

Greptile Summary

This PR aligns the Dockerfile build behavior with the Docker context input’s documented default by resolving an unset context path to the application’s code root.

  • Makes getDockerContextPath always return an absolute workspace path, defaulting to . beneath the code directory.
  • Removes the Dockerfile-directory fallback from Docker command generation.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness or security issues identified.

The changed resolver and Docker command remain aligned: an unset context now resolves to the application code root, while explicitly configured context paths continue to resolve beneath the same workspace.

Reviews (1): Last reviewed commit: "fix/docker-context-path-default: Placeho..." | Re-trigger Greptile

…kerContextPath" lied that the default path is ".", while being the Dockerfile directory.
@drago1520
drago1520 requested a review from Siumauricio as a code owner August 31, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant