fix(swarm): report failed service rollouts - #5218
Open
bestmaa wants to merge 2 commits into
Open
Conversation
|
super excited |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm typecheckpnpm buildpnpm --filter dokploy exec vitest run --config __test__/vitest.config.ts __test__/server/swarm-update.test.ts __test__/server/mechanizeDockerContainer.test.ts(16 tests passed)completed, while an unhealthy update automatically rolled back and surfaced the failed task reasonFixes #3987
Happy to adjust the polling states or failure details if you would prefer a different approach.
Greptile Summary
This PR waits for existing Swarm application-service updates to reach a terminal state and reports paused or rolled-back rollouts with task failure details.
Confidence Score: 3/5
The PR should not merge until rollout waits are correlated to the initiating update and valid configured rollouts cannot be prematurely failed by the fixed one-hour cap.
Concurrent direct service mutations can make the waiter attribute another update’s terminal state to the current deployment, while accepted long-duration Swarm settings can exceed the capped wait and produce false deployment failures.
Files Needing Attention: packages/server/src/utils/docker/swarm-update.ts and packages/server/src/utils/builders/index.ts
Reviews (1): Last reviewed commit: "fix(swarm): report failed service rollou..." | Re-trigger Greptile
Context used (3)