fix(notifications): add missing serverThreshold for gotify/ntfy and f… - #5176
Open
abhi128nandan wants to merge 3 commits into
Open
fix(notifications): add missing serverThreshold for gotify/ntfy and f…#5176abhi128nandan wants to merge 3 commits into
abhi128nandan wants to merge 3 commits into
Conversation
…ix teams error boundary
abhi128nandan
force-pushed
the
fix/gotify-ntfy-server-threshold
branch
from
August 24, 2026 09:11
8dad085 to
dedc0c1
Compare
Author
|
Hi @Siumauricio, could you please take a look at this PR when you get a chance? Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR fixes two separate issues with the server threshold notification system. First, it adds the missing
serverThresholdproperty to the Gotify and Ntfy schemas, service insert/update functions, and frontend UI forms so the preference correctly persists to the database. Second, it moves the Teams notification dispatch inserver-threshold.tsinside thetry/catcherror boundary to prevent an unhandled rejection from aborting the entire notification processing loop.Checklist
Before submitting this PR, please make sure that:
canarybranch.https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
Issues related (if applicable)
closes #5175
Screenshots (if applicable)
(No visual UI changes, just backend persistence/error boundary fixes)
Greptile Summary
This PR completes Gotify and Ntfy server-threshold persistence across the UI, API schema, and notification services, and moves Teams delivery inside the notification loop’s error boundary.
serverThresholdthrough Gotify and Ntfy form initialization and mutation payloads.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Reviews (3): Last reviewed commit: "Merge branch 'Dokploy:canary' into fix/g..." | Re-trigger Greptile