Skip to content

fix(notifications): add missing serverThreshold for gotify/ntfy and f… - #5176

Open
abhi128nandan wants to merge 3 commits into
Dokploy:canaryfrom
abhi128nandan:fix/gotify-ntfy-server-threshold
Open

fix(notifications): add missing serverThreshold for gotify/ntfy and f…#5176
abhi128nandan wants to merge 3 commits into
Dokploy:canaryfrom
abhi128nandan:fix/gotify-ntfy-server-threshold

Conversation

@abhi128nandan

@abhi128nandan abhi128nandan commented Aug 24, 2026

Copy link
Copy Markdown

What is this PR about?

This PR fixes two separate issues with the server threshold notification system. First, it adds the missing serverThreshold property to the Gotify and Ntfy schemas, service insert/update functions, and frontend UI forms so the preference correctly persists to the database. Second, it moves the Teams notification dispatch in server-threshold.ts inside the try/catch error boundary to prevent an unhandled rejection from aborting the entire notification processing loop.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file
    https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #5175

Screenshots (if applicable)

(No visual UI changes, just backend persistence/error boundary fixes)

Greptile Summary

This PR completes Gotify and Ntfy server-threshold persistence across the UI, API schema, and notification services, and moves Teams delivery inside the notification loop’s error boundary.

  • Passes serverThreshold through Gotify and Ntfy form initialization and mutation payloads.
  • Accepts and persists the flag in Gotify and Ntfy create/update paths.
  • Contains Teams delivery failures within the existing per-notification error handler.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "Merge branch 'Dokploy:canary' into fix/g..." | Re-trigger Greptile

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 24, 2026
Comment thread packages/server/package.json Outdated
@abhi128nandan
abhi128nandan force-pushed the fix/gotify-ntfy-server-threshold branch from 8dad085 to dedc0c1 Compare August 24, 2026 09:11
@abhi128nandan

Copy link
Copy Markdown
Author

Hi @Siumauricio, could you please take a look at this PR when you get a chance? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gotify and Ntfy settings fail to persist serverThreshold preference + Teams notification unhandled rejection

1 participant