Skip to content

feat(vault): Added 1Password secrets provider - #5154

Open
bjerringgaard wants to merge 5 commits into
Dokploy:canaryfrom
bjerringgaard:canary
Open

feat(vault): Added 1Password secrets provider#5154
bjerringgaard wants to merge 5 commits into
Dokploy:canaryfrom
bjerringgaard:canary

Conversation

@bjerringgaard

@bjerringgaard bjerringgaard commented Aug 21, 2026

Copy link
Copy Markdown

What is this PR about?

Added 1Password as an option for the vault-providers.
Making use of 1password's newer "Environments" feature.
Relying on 1Password's Service Account Authentication

Checklist

Before submitting this PR, please make sure that:

  • [✔︎ ] You created a dedicated branch based on the canary branch.
  • [✔︎ ] You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • [✔︎] You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #1777
closes #1192

Greptile Summary

The PR adds 1Password Environments as a vault provider using service-account authentication.

  • Adds the provider schema, persistence migration, server-side client, and vault dispatch integration.
  • Adds dashboard configuration fields, provider labeling, and icon support.
  • Adds tests for authentication, secret retrieval, connection checks, name listing, and reference resolution.
  • The previously reported unbounded request path is now protected by the shared vault timeout helper.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously unbounded 1Password SDK operations now reject through the shared vault timeout wrapper.

Reviews (4): Last reviewed commit: "fix: added tests" | Re-trigger Greptile

Context used:

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 21, 2026
Comment thread packages/server/src/utils/vault/onepassword.ts Outdated

@narcisonunez narcisonunez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this. You can add them in __test__/env/vault.test.ts with a describe as the other providers do.

@bjerringgaard

Copy link
Copy Markdown
Author

@narcisonunez Tests have now been added.

@bjerringgaard bjerringgaard changed the title feat(vault): Added 1Password as Secrets provider feat(vault): Added 1Password secrets provider Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate with 1Password 1Password integration

2 participants