fix(registry): preserve username case for ECR compatibility#4647
Open
rafaumeu wants to merge 1 commit into
Open
fix(registry): preserve username case for ECR compatibility#4647rafaumeu wants to merge 1 commit into
rafaumeu wants to merge 1 commit into
Conversation
…4632) Remove .toLowerCase() transform from registryUsernameSchema. AWS ECR requires the username to be exactly 'AWS' (uppercase) for authentication. Docker Hub usernames are case-insensitive for login, so preserving case is safe for all providers. Closes Dokploy#4632
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #4632
The registry username schema applied a
.toLowerCase()transform, which breaks AWS ECR authentication. ECR requires the username to be exactlyAWS(uppercase). With the current code,AWSbecomesawsand authentication fails.Solution
Removed the
.toLowerCase()transform fromregistryUsernameSchema. The schema now only trims whitespace and validates non-empty.This is safe because:
AWS(uppercase) — now preservedTesting
Added 6 unit tests in
__test__/registry/registry-schema.test.ts:apiTestRegistrytoo