feat: implement postgres password update and fix swarm container resolution#3368
Closed
JuansesDev wants to merge 1 commit intoDokploy:canaryfrom
Closed
feat: implement postgres password update and fix swarm container resolution#3368JuansesDev wants to merge 1 commit intoDokploy:canaryfrom
JuansesDev wants to merge 1 commit intoDokploy:canaryfrom
Conversation
Contributor
|
Fixed here #4144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the ability to update the Postgres database password directly from the Dokploy Dashboard. It ensures that the password is synchronously updated in three places: the Docker container (via
ALTER USER), the Dokploy internal database, and the environment variables of any dependent applications within the same organization.Additionally, it includes a critical fix for Docker Swarm environments where
docker execcommands were failing because they attempted to use the Service Name instead of the Container ID.Changes:
Backend (
packages/server/src/services/postgres.ts):changePostgresPasswordservice function.docker ps -q -f name=...) before executing commands, solving stability issues in Swarm.DATABASE_URLin dependent apps when the password changes.execAsyncRemotecalls to properly handle stdout.API (
apps/dokploy/server/api/routers/postgres.ts):changePasswordprotected procedure to the postgres router.Frontend (
show-internal-postgres-credentials.tsx):Type of Change:
How Has This Been Tested?
docker execcommands successfully target the running container in a Swarm environment.Checklist: