Skip to content

Conversation

@frankieyan
Copy link
Member

Remove the engines field that required Node.js ^22.22.0 and npm ^10.9.2. This allows consumers to install @doist/reactist regardless of their Node.js version, since it's a client-side library that runs in the browser.

The engines field was added to support @doist/react-compiler-tracker (a dev dependency), not for any runtime requirements. Development is still protected by the .node-version file and CI workflows.

Also updates @doist/react-compiler-tracker to 2.1.2, which relaxes its Node.js engine requirement to support Node 20.

🤖 Generated with Claude Code

frankieyan and others added 2 commits January 26, 2026 14:37
Remove the `engines` field that required Node.js ^22.22.0 and npm ^10.9.2. This allows consumers to install `@doist/reactist` regardless of their Node.js version, since it's a client-side library that runs in the browser.

The `engines` field was added to support `@doist/react-compiler-tracker` (a dev dependency), not for any runtime requirements. Development is still protected by the `.node-version` file and CI workflows.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link

@doist-bot doist-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this pull request correctly remove the engines field from package.json and update @doist/react-compiler-tracker to version 2.1.2, which in turn relaxes its Node.js engine requirement. All modifications align with the stated goal of allowing consumers to install the library regardless of their Node.js version, as it's a client-side library. The changes are consistent across package.json and package-lock.json.

@frankieyan frankieyan requested review from a team and pawelgrimm and removed request for a team January 26, 2026 22:50
@frankieyan frankieyan added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Jan 26, 2026
Copy link
Contributor

@pawelgrimm pawelgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🙏

@frankieyan frankieyan merged commit af7ce99 into main Jan 26, 2026
6 checks passed
@frankieyan frankieyan deleted the frankieyan/remove-engines-field branch January 26, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants