Skip to content

feat!: Update Node.js support to 24#64

Open
AfzalivE wants to merge 2 commits into
mainfrom
codex/update-node-24
Open

feat!: Update Node.js support to 24#64
AfzalivE wants to merge 2 commits into
mainfrom
codex/update-node-24

Conversation

@AfzalivE

@AfzalivE AfzalivE commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

Updates the repo's default Node.js version to Node 24 and aligns the supported runtime metadata with the currently supported LTS lines.

Changes

  • Set .nvmrc to 24.
  • Updated engines.node in package.json and package-lock.json to ^22.0.0 || ^24.0.0.
  • Updated pull request CI to run on Node 22.x and 24.x.

Validation

Ran locally with Node v24.16.0 / npm 11.13.0:

  • npm test
  • npm run lint
  • npm run build
  • git diff --check

All passed. The existing Browserslist and Rollup warnings still appear during checks, but they are non-blocking.

[codex]

@AfzalivE AfzalivE marked this pull request as ready for review June 17, 2026 18:07

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates chore: Update Node.js support to 24. No issues were flagged in the reviewed diff.

Share FeedbackReview Logs

@AfzalivE AfzalivE requested a review from gnapse June 17, 2026 18:09
@AfzalivE AfzalivE changed the title [codex] Update Node.js support to 24 chore: Update Node.js support to 24 Jun 17, 2026
@AfzalivE

Copy link
Copy Markdown
Member Author

@scottlovegrove Since this is a breaking change for Node v16 and v18, do you think it's better to do this in #61 instead with v3?

@scottlovegrove scottlovegrove changed the title chore: Update Node.js support to 24 feat!: Update Node.js support to 24 Jun 17, 2026
@scottlovegrove

Copy link
Copy Markdown
Contributor

@AfzalivE I've updated the title to feat!: which, when merged, should trigger a major version update. I mentioned to @gnapse earlier that we should do this for v3, then the changes in his PR would become v4 instead, otherwise we could be blocked on #61.

strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [22.x, 24.x]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote here is we just drop node 22 at this point. @gnapse thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants