Skip to content

docs(thread): document group IDs in --notify help text#34

Merged
lmjabreu merged 2 commits into
mainfrom
docs/notify-groups
Jun 18, 2026
Merged

docs(thread): document group IDs in --notify help text#34
lmjabreu merged 2 commits into
mainfrom
docs/notify-groups

Conversation

@lmjabreu

@lmjabreu lmjabreu commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Short description

tdc thread reply/create --notify already accepts custom group IDs (they're partitioned from user IDs in resolveNotifyIds and sent as groups), with test coverage (thread.test.ts "partitions notify IDs into users and groups"). But the --notify help text only mentioned "user IDs", so the capability was undiscoverable from --help — especially since Comms group IDs are non-numeric base58 strings that look nothing like a user ID.

This updates both option descriptions (reply + create) to mention group IDs, and adds a group-notify line to thread reply's existing example block (alongside --close / --file). No behaviour change.

Verified the path works today with a live dry-run:

$ tdc thread reply <thread> "..." --notify Cbzzn7qrnZgPm5ibXCSrV --dry-run
  Notify groups: 25Q3|Compensation Squad (Cbzzn7qrnZgPm5ibXCSrV)

Test plan

  • npm run type-check
  • npm run lint
  • npx vitest run src/commands/thread (84 passing)
  • tdc thread reply --help renders the updated text

@doistbot doistbot requested a review from scottlovegrove June 17, 2026 23:03

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the --notify help text for thread reply and thread create to document that group IDs are accepted alongside user IDs, plus adds a group-notify example — a small, docs-only change with no behavioural impact.

Few things worth tightening:

  • Per the repo's AGENTS.md guidelines, src/lib/skills/content.ts (SKILL_CONTENT) should also be updated to reflect the --notify group-ID support and new example, so AI agent skill guidance stays in sync with the CLI help text.

Share FeedbackReview Logs

Comment thread src/commands/thread/index.ts
@lmjabreu lmjabreu force-pushed the docs/notify-groups branch from d027f6a to bcf1da8 Compare June 17, 2026 23:10
`tdc thread reply/create --notify` already accepts custom group IDs
(partitioned via resolveNotifyIds → groups), but the help text only
mentioned "user IDs". Since Comms group IDs are non-numeric base58
strings that look nothing like user IDs, the capability was effectively
undiscoverable from --help. Mention groups in both option descriptions
and add a group-notify example to the reply command's existing example
block (alongside --close / --file).

No behaviour change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@lmjabreu lmjabreu force-pushed the docs/notify-groups branch from bcf1da8 to dfa83f1 Compare June 17, 2026 23:35
Per AGENTS.md, src/lib/skills/content.ts must track command-description and
example changes. The reply/create --notify examples said "users" only; make
them mention groups and add a group-notify example (base58 group ID next to a
numeric user ID). Regenerated skills/comms-cli/SKILL.md via `sync:skill`;
check:skill-sync passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@lmjabreu lmjabreu merged commit 336ed4a into main Jun 18, 2026
5 checks passed
@lmjabreu lmjabreu deleted the docs/notify-groups branch June 18, 2026 11:06
@doist-release-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants