docs(thread): document group IDs in --notify help text#34
Merged
Conversation
doistbot
reviewed
Jun 17, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates the --notify help text for thread reply and thread create to document that group IDs are accepted alongside user IDs, plus adds a group-notify example — a small, docs-only change with no behavioural impact.
Few things worth tightening:
- Per the repo's
AGENTS.mdguidelines,src/lib/skills/content.ts(SKILL_CONTENT) should also be updated to reflect the--notifygroup-ID support and new example, so AI agent skill guidance stays in sync with the CLI help text.
d027f6a to
bcf1da8
Compare
`tdc thread reply/create --notify` already accepts custom group IDs (partitioned via resolveNotifyIds → groups), but the help text only mentioned "user IDs". Since Comms group IDs are non-numeric base58 strings that look nothing like user IDs, the capability was effectively undiscoverable from --help. Mention groups in both option descriptions and add a group-notify example to the reply command's existing example block (alongside --close / --file). No behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bcf1da8 to
dfa83f1
Compare
Per AGENTS.md, src/lib/skills/content.ts must track command-description and example changes. The reply/create --notify examples said "users" only; make them mention groups and add a group-notify example (base58 group ID next to a numeric user ID). Regenerated skills/comms-cli/SKILL.md via `sync:skill`; check:skill-sync passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
scottlovegrove
approved these changes
Jun 18, 2026
Contributor
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
tdc thread reply/create --notifyalready accepts custom group IDs (they're partitioned from user IDs inresolveNotifyIdsand sent asgroups), with test coverage (thread.test.ts"partitions notify IDs into users and groups"). But the--notifyhelp text only mentioned "user IDs", so the capability was undiscoverable from--help— especially since Comms group IDs are non-numeric base58 strings that look nothing like a user ID.This updates both option descriptions (reply + create) to mention group IDs, and adds a group-notify line to
thread reply's existing example block (alongside--close/--file). No behaviour change.Verified the path works today with a live dry-run:
Test plan
npm run type-checknpm run lintnpx vitest run src/commands/thread(84 passing)tdc thread reply --helprenders the updated text