fix(refs): tighten inbox/saved thread URL routing#32
Merged
Conversation
doistbot
reviewed
Jun 16, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
Tightens inbox and saved URL routing to accept only t/{thread} with an optional c/{comment} suffix, preventing malformed trailing segments from being misrouted. No issues were flagged.
Bloomca
approved these changes
Jun 16, 2026
Bloomca
left a comment
Bloomca
left a comment
There was a problem hiding this comment.
Looks good to me, but I think we can improve the documentation with some examples as the logic is hard to read
Only classify `t/{thread}` with an optional `c/{comment}` suffix after
inbox/saved; extra trailing segments stay unclassified so malformed URLs
aren't misrouted (e.g. as a conversation). Groups the branch by route
prefix and adds saved-thread + strictness test coverage.
Addresses review on #30.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amix
force-pushed
the
amix/tighten-inbox-thread-url-routing
branch
from
1e8d409 to
c6dfbe6
Compare
Member
Author
|
@Bloomca I did a jab at making it less arcane. I’ll merge this in, but please if you disagree, I can do a follow-up PR to clean things up 👍 |
doist-release-bot Bot
added a commit
that referenced
this pull request
Jun 17, 2026
## [1.6.5](v1.6.4...v1.6.5) (2026-06-17) ### Bug Fixes * **refs:** tighten inbox/saved thread URL routing ([#32](#32)) ([8a0090e](8a0090e))
Contributor
|
🎉 This PR is included in version 1.6.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #30. Doistbot flagged that inbox/saved branches parsed all trailing route pairs, so a malformed URL like
inbox/t/TH1/msg/CV1could be misrouted as a conversation.What was changed
inbox/saved, onlyt/{thread}with an optionalc/{comment}suffix is classified; extra segments stay unclassified.savedthread test cases + a strictness regression test.Refs
Review: #30 (review)