fix: generate canonical Comms search URLs#26
Merged
Conversation
doistbot
reviewed
Jun 15, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates fix: generate canonical Comms search URLs. No inline issues were flagged.
I also included a few optional follow-up notes in the details below.
Optional follow-up note (1)
- [P3] src/lib/search-helpers.ts:214:
buildSearchResultUrlis only called withSearchResultitems (response.items.map(...)below), but this adds another field to a local shadow shape instead of reusing that SDK type. Keepingtypeas plainstringand manually mirroring fields here makes this helper easy to drift out of sync as the search result contract evolves. PreferSearchResultitself, or at leastPick<SearchResult, 'id' | 'type' | 'threadId' | 'channelId' | 'conversationId' | 'commentId'>.
doist-release-bot Bot
added a commit
that referenced
this pull request
Jun 15, 2026
## [1.6.3](v1.6.2...v1.6.3) (2026-06-15) ### Bug Fixes * generate canonical Comms search URLs ([#26](#26)) ([b4bcc77](b4bcc77))
Contributor
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Am I correct in assuming it is wrong? My
tdcCLI was giving me links with the/asection in front of the workspace ID, and the links did not work.So this PR changes the CLI so that…