Repository navigation
CI only: fix(images): embed 16-bit PNGs with alpha, palette PNGs and tRNS transparency - #2
Draft
ndbroadbent wants to merge 1 commit into
Draft
ndbroadbent wants to merge 1 commit into
ndbroadbent wants to merge 1 commit into
Conversation
…sparency The alpha path decoded a 16-bit PNG without stripping it to 8 bits, so each pixel's samples were written as two 8-bit pixels under an 8-bit dictionary: the image was garbled, in the wrong colors and transparency. parse_png rejects palette PNGs, so a palette PNG as a CSS background drew nothing, and the raw IDAT pass-through ignored a tRNS chunk's transparency. The resource loader now re-encodes those PNGs as 8-bit RGB or RGBA once per resource, so every image path (<img>, CSS backgrounds, border images, SVG images) gets one it can embed, and the alpha decoder expands palettes and strips 16-bit samples as well.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs CI and the parity gate for an upstream PR to gastongouron/ironpress. Not for merging.