RS-22478: fix stored XSS in heatmap tooltips#59
Merged
Conversation
HTML-escape the axis titles and extra-tooltip-info keys rendered into the tooltip (the cell values/names were already escaped). Rebuilt the inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Remember to bump the version |
JustinCCYap
approved these changes
Jun 12, 2026
JustinCCYap
left a comment
JustinCCYap
left a comment
Contributor
There was a problem hiding this comment.
LGTM, see comment about bumping the version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML-escape the axis titles and extra-tooltip-info keys rendered into the tooltip (the cell values/names were already escaped).