Feature/android navigation transitions - #2416
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6e4071b41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val horizontalOffset = | ||
| if (isIncoming) { | ||
| -enteringStartOffset | ||
| } else if (motion.swipeEdge == NavigationEvent.EDGE_LEFT) { | ||
| easedProgress * (width * (1f - PREDICTIVE_BACK_TARGET_SCALE) / 2f - displayMargin) | ||
| } else { | ||
| 0f |
There was a problem hiding this comment.
Mirror predictive motion for right-edge back gestures
When Android reports EDGE_RIGHT—which is possible with two-sided gesture navigation and is the usual back edge in RTL—the outgoing scene receives no horizontal translation, while the incoming scene is still offset to the left. The animation therefore does not move toward the touched edge and remains LTR-oriented; mirror these offsets for right-edge/RTL gestures.
Useful? React with 👍 / 👎.
No description provided.