Skip to content

Feature/android navigation transitions - #2416

Merged
Tlaster merged 3 commits into
masterfrom
feature/android-navigation-transitions
Aug 17, 2026
Merged

Feature/android navigation transitions#2416
Tlaster merged 3 commits into
masterfrom
feature/android-navigation-transitions

Conversation

@Tlaster

@Tlaster Tlaster commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6e4071b41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +405 to +411
val horizontalOffset =
if (isIncoming) {
-enteringStartOffset
} else if (motion.swipeEdge == NavigationEvent.EDGE_LEFT) {
easedProgress * (width * (1f - PREDICTIVE_BACK_TARGET_SCALE) / 2f - displayMargin)
} else {
0f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mirror predictive motion for right-edge back gestures

When Android reports EDGE_RIGHT—which is possible with two-sided gesture navigation and is the usual back edge in RTL—the outgoing scene receives no horizontal translation, while the incoming scene is still offset to the left. The animation therefore does not move toward the touched edge and remains LTR-oriented; mirror these offsets for right-edge/RTL gestures.

Useful? React with 👍 / 👎.

@Tlaster
Tlaster merged commit 913fea2 into master Aug 17, 2026
9 checks passed
@Tlaster
Tlaster deleted the feature/android-navigation-transitions branch August 17, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant