Repository navigation
Conversation
Signed-off-by: Emmanuel Mawulolo Tagbor <etagbor@gmail.com>
Member
|
Thanks, this looks good: the fail-closed cases are well covered and CI is green. One simplification before merging: instead of the new The existing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses item 3 of #330.
DiffCI now recognizes
uv --directory dify-agent run --project . pyrefly checkas a Python type check. A Python change schedules the original command, including its directory and project arguments. A README-only change skips it. A Make target whose recipe contains that literal check can make the same decision.Before
run, the planner accepts--directoryand--projectwith simple repository-relative paths, plus--offlineand--no-progress. Unsupported options or missing operands leave a direct command out. If a Make variable can supply part of the new invocation, the target still runs as written. Auv.tomlchange runs the newly recognized checks because that file can change the environment uv selects.The synthetic regression models the literal Dify command from the issue. Running the same three Git changes through
diffci verifyand its planner on upstream and the patch confirmed the Python, README anduv.tomldecisions, including the missing-runner explanation. Two regression tests fail on upstream and pass with the patch. The full Core run passed 1,405 tests. Its 16 skipped Go and Cargo cases passed in a separate run with the toolchains on PATH. Typecheck, build, release boundary, agent packaging and benchmark also passed.