Skip to content

fix(impact): name mise.local.toml with the other tool-version files - #332

Merged
adityankale190895 merged 1 commit into
DiffCI:mainfrom
tyza66:fix/mise-local-tool-versions
Nov 19, 2026
Merged

adityankale190895 merged 1 commit into
DiffCI:mainfrom
tyza66:fix/mise-local-tool-versions

Conversation

@tyza66

@tyza66 tyza66 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #321 (merged as #326), from your note on that PR.

mise.local.toml and .mise.local.toml are mise's machine-local override, so they pick the toolchain exactly as mise.toml does, and both still came out as Unknown changed file.

Rather than a second pattern, the existing one covers the family:

/^\.?mise(?:\.local)?\.toml$/,

and toolConfigurationSubject matches it with the same expression instead of listing four names:

if (base === ".tool-versions" || /^\.?mise(?:\.local)?\.toml$/.test(base)) return "tool versions";

Tests

  • tests/repo/tool-config-reasons.test.ts: one case each for mise.local.toml and .mise.local.toml, through the existing body (FULL, every test selected, reason starts with Tool configuration changed: tool versions and names the path, no Unknown).
  • tests/repo/config-patterns.test.ts: the example for the mise entry becomes mise.local.toml, so the widened pattern is still paired with a real file name that only it matches. The other three still pass their own entries.
  • The docs row lists both names.

Checks

npm test: 1399 pass, 10 fail, and the ten are the same Cargo/Rust execution tests that fail on unmodified main in this environment (tests/repo/rust-execution.test.ts and its siblings, 101 !== 0 from a cargo test target that doesn't build here). Hosted CI is green on #326 for the same reason. npm run typecheck and npm run audit:boundary (450 files) pass.

DiffCI#326 named `.tool-versions`, `mise.toml`, `.mise.toml` and `.bun-version`
after review suggested, correctly, that `mise.local.toml` and
`.mise.local.toml` still came out as `Unknown changed file`. They are mise's
machine-local override, so they pick the toolchain exactly as `mise.toml`
does.

The pattern grows to `/^\.?mise(?:\.local)?\.toml$/` rather than a second
entry, so one example still covers the family, and `toolConfigurationSubject`
matches it with the same expression instead of listing four names.

- `tests/repo/tool-config-reasons.test.ts` gets one case per new name.
- `tests/repo/config-patterns.test.ts`'s example becomes `mise.local.toml`,
  which the widened pattern still has to match.
- The docs row lists both.

Signed-off-by: 孙达明 <83948628+tyza66@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 01:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@adityankale190895
adityankale190895 merged commit ff296bd into DiffCI:main Nov 19, 2026
13 checks passed
@adityankale190895

Copy link
Copy Markdown
Member

Thanks @tyza66, merged. If you want to talk through a change before you open it, or just chat about CI, we have a Discord now: https://discord.gg/vAftSVeYgk (#contributing).

adityankale190895 added a commit that referenced this pull request Nov 19, 2026
Moves the CLI's Core pin to 722ff89 so #328 and #332 ship.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: adityankale190895 <adityankale1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants