Repository navigation
fix(impact): name mise.local.toml with the other tool-version files - #332
Merged
adityankale190895 merged 1 commit intoNov 19, 2026
Merged
Conversation
DiffCI#326 named `.tool-versions`, `mise.toml`, `.mise.toml` and `.bun-version` after review suggested, correctly, that `mise.local.toml` and `.mise.local.toml` still came out as `Unknown changed file`. They are mise's machine-local override, so they pick the toolchain exactly as `mise.toml` does. The pattern grows to `/^\.?mise(?:\.local)?\.toml$/` rather than a second entry, so one example still covers the family, and `toolConfigurationSubject` matches it with the same expression instead of listing four names. - `tests/repo/tool-config-reasons.test.ts` gets one case per new name. - `tests/repo/config-patterns.test.ts`'s example becomes `mise.local.toml`, which the widened pattern still has to match. - The docs row lists both. Signed-off-by: 孙达明 <83948628+tyza66@users.noreply.github.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Member
|
Thanks @tyza66, merged. If you want to talk through a change before you open it, or just chat about CI, we have a Discord now: https://discord.gg/vAftSVeYgk ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #321 (merged as #326), from your note on that PR.
mise.local.tomland.mise.local.tomlare mise's machine-local override, so they pick the toolchain exactly asmise.tomldoes, and both still came out asUnknown changed file.Rather than a second pattern, the existing one covers the family:
and
toolConfigurationSubjectmatches it with the same expression instead of listing four names:Tests
tests/repo/tool-config-reasons.test.ts: one case each formise.local.tomland.mise.local.toml, through the existing body (FULL, every test selected, reason starts withTool configuration changed: tool versionsand names the path, noUnknown).tests/repo/config-patterns.test.ts: the example for the mise entry becomesmise.local.toml, so the widened pattern is still paired with a real file name that only it matches. The other three still pass their own entries.Checks
npm test: 1399 pass, 10 fail, and the ten are the same Cargo/Rust execution tests that fail on unmodifiedmainin this environment (tests/repo/rust-execution.test.tsand its siblings,101 !== 0from acargo testtarget that doesn't build here). Hosted CI is green on #326 for the same reason.npm run typecheckandnpm run audit:boundary(450 files) pass.