SPA metadata source should include Images-Disc #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-riggs
requested review from
d-j-hatton and
tieneupin
and removed request for
d-j-hatton
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 46.59% 46.58% -0.02%
==========================================
Files 91 91
Lines 9634 9630 -4
Branches 1262 1262
==========================================
- Hits 4489 4486 -3
Misses 4932 4932
+ Partials 213 212 -1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Images-Discpart of the source needs to be included as part of the tag, but this meant that theEpuSession.dmwas being searched for in the wrong location.This PR makes sure the
Images-Discis always sent forensure_dcg_existsin SPA, and then that searches for the dm file in the parent folder. Also ensures dcg exists for all images folders when metadata files are seen.