Conversation
stephen-riggs
commented
Jan 9, 2026
- The recursive machine config update did not work for dictionaries as this caused in-place modification of the memory location of the general config
- The destination selection needs to not run with string None
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 43.98% 43.99%
=======================================
Files 93 93
Lines 10189 10190 +1
Branches 1320 1320
=======================================
+ Hits 4482 4483 +1
Misses 5486 5486
Partials 221 221 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Looks good to me! Thanks for fixing it and for writing some tests to address it.
MyPy revealed some typing-related errors in murfey.client.analyser and murfey.client.contexts.spa that I've tried to handle as well. Could you let me know if those changes are alright?
Yes, the typing looks fine |