Replace first_poll logic with update_period=ONCE#78
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 84.42% 84.86% +0.43%
==========================================
Files 13 13
Lines 411 403 -8
==========================================
- Hits 347 342 -5
+ Misses 64 61 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
force-pushed
the
update-once
branch
from
02545e6 to
d945075
Compare
shihab-dls
approved these changes
Dec 1, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Just one nit, everything else looks good to me, so I'll approve and you can address the nit if you'd like!
Remove try in update. FastCS catches these exceptions now.
GDYendell
force-pushed
the
update-once
branch
from
d945075 to
503aeb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.