test: Enable auth for numtracker - #1619
Merged
ZohebShaikh merged 2 commits intoAug 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 45 45
Lines 3317 3317
=======================================
Hits 3183 3183
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
changed the title
tpoliaw
approved these changes
Aug 11, 2026
Comment on lines
+11
to
+12
| - NUMTRACKER_AUTH_ADMIN=v1/data/diamond/policy/admin/configure_beamline | ||
| command: ["serve","-v", "--port", "8406"] |
Contributor
There was a problem hiding this comment.
Seems odd to mix configuration between CLI args and environment variables
Suggested change
| - NUMTRACKER_AUTH_ADMIN=v1/data/diamond/policy/admin/configure_beamline | |
| command: ["serve","-v", "--port", "8406"] | |
| - NUMTRACKER_AUTH_ADMIN=v1/data/diamond/policy/admin/configure_beamline | |
| - NUMTRACKER_PORT=8406 | |
| - NUMTRACKER_LOG_LEVEL=info |
ZohebShaikh
force-pushed
the
add-auth-numtracker
branch
from
August 12, 2026 10:20
6cd450f to
be766be
Compare
ZohebShaikh
force-pushed
the
add-auth-numtracker
branch
from
August 12, 2026 10:21
be766be to
651c834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.