Closed
Conversation
…(meta BSDF) is not yet complete!
# Conflicts: # examples_tests
…_assert_2026_04_01 Update DXC for EX40 lexed inline method assert fix
- `getSumOfArccosMinusPi()` and `getClampedSumOfArccosMinusPi()` a good way to prevent catastrophic cancellation and NaNs - `sincos()` now uses sin and cos, no tricks, faster and more accurate - linear and bilinear are simpler and faster - spherical triangle templated version that is bijective (will probably remove all this boilerplate cus it doesn't make a perf difference)
…ing/Nabla into sampler-concepts # Conflicts: # include/nbl/builtin/hlsl/sampling/spherical_triangle.hlsl
# Conflicts: # tools/nsc/manifests/nsc-windows-x64-release.tag # tools/nsc/manifests/nsc-windows-x64-release/exe/tools/nsc/bin/build-info.json.dvc # tools/nsc/manifests/nsc-windows-x64-release/exe/tools/nsc/bin/nsc.exe.dvc # tools/nsc/manifests/nsc-windows-x64-release/runtime/nbl/3rdparty/dxc/dxcompiler.dll.dvc # tools/nsc/manifests/nsc-windows-x64-release/runtime/nbl/Nabla.dll.dvc
…y' into path_tracer_beauty
…creation Hotfix tlas creation
# Conflicts: # examples_tests # include/nbl/ext/FullScreenTriangle/FullScreenTriangle.h # src/nbl/ext/FullScreenTriangle/CFullScreenTriangle.cpp
The shared preprocess renderer rebuilt spacing from Wave tokens and also inserted synthetic newlines whenever the next token came from a later logical line or a different file. That heuristic is not required for valid output. Wave already gives us explicit whitespace tokens and insert_whitespace_detection tells us when a separator is needed to keep adjacent tokens distinct. Reconstructing extra physical line breaks from token source positions adds formatting that was not present in the emitted token stream. Macro expansion makes those source positions unsafe for layout reconstruction. Tokens from one expanded construct can report later logical lines or different source files even though they must stay on the same physical output line. The renderer then drifts the preprocessed text and diagnostics point at lines later than the real source location. Drop the synthetic newline inference and keep only the required space insertion between non-whitespace tokens. This preserves valid output while keeping diagnostics aligned with the original source lines.
The current examples submodule pointer fails the Windows Debug examples build in EX31 because RenderPushConstants::setLightMatrix asserts through a nonexistent lightMatrix() member. Point the submodule to the official companion fix so this branch can validate against green CI.
Fix Wave diagnostic line drift
# Conflicts: # examples_tests # include/nbl/builtin/hlsl/path_tracing/gaussian_filter.hlsl # include/nbl/builtin/hlsl/sampling/basic.hlsl # include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl
# Conflicts: # examples_tests
…pressure and fix some warnings
# Conflicts: # examples_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.