Add authenticated Artifact Signing profile root retrieval - #35
Open
nurfed1 wants to merge 1 commit into
Open
Conversation
Add an artifact-signing-root portable command backed by the Artifact Signing REST client. Reuse the existing credential modes, constrain and validate the service endpoint before acquiring credentials, bound response bodies, and require the successful response to contain a DER-encoded CA certificate before writing it. Include focused HTTP, validation, CLI, and documentation coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Azure Artifact Signing certificate profiles can use a profile-specific root that
is not present in the normal public AuthRoot set. Consumers that need to verify
test or private-trust signatures should retrieve the root associated with the
selected profile instead of embedding a certificate that may later change.
Azure exposes an authenticated profile root-certificate operation, but psign's
portable Artifact Signing client currently only implements the signing
operation.
Change
Add an
artifact-signing-rootportable command and the corresponding operationto
psign-codesigning-rest.The command:
certificate profile;
it;
Example:
Endpoint and response safety
The implementation:
codesigning.azure.netorartifactsigning.azure.net;Validation
Added focused tests covering:
The full fork CI matrix passes, including Unix portable checks,
artifact-signing-restfeature tests, clippy, formatting, .NET tool packaging,and PowerShell module tests.
The command was also exercised against a live Azure Artifact Signing test
profile using federated credentials. The returned root was used to verify a PE
signed by that profile successfully.