Support additive trust anchors in portable verification - #34
Open
nurfed1 wants to merge 1 commit into
Open
Conversation
Add a repeatable --additional-trusted-ca option for augmenting the selected portable trust set without disabling the automatic Microsoft AuthRoot source. Keep --trusted-ca and --anchor-dir as replacing inputs, apply the behavior consistently across portable trust commands, and document and test the source-selection policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Portable trust verification automatically uses the Microsoft AuthRoot source when
no explicit anchors are supplied.
The existing
--trusted-caand--anchor-diroptions intentionally replace thatautomatic trust source. This makes it awkward to trust an additional
profile-specific, private, or test CA while retaining the normal Microsoft roots.
Callers currently have to replace or reconstruct the complete trust set.
Change
Add a repeatable
--additional-trusted-ca <PATH>option to the shared portabletrust-verification arguments.
The new option:
--trusted-ca,--anchor-dir, or--authroot-cabinputs;
--trusted-ca.Existing
--trusted-caand--anchor-dirreplacement behavior is unchanged.Documentation and the CLI capability matrix are updated to describe the
distinction between replacing and additive anchors.
Validation
Added focused tests covering:
The full fork CI matrix passes, including Unix portable checks, feature-specific
CLI tests, clippy, formatting, .NET tool packaging, and PowerShell module tests.
The behavior was also integration-tested with an Azure Artifact Signing test
profile: its authenticated profile root was added to the automatic Microsoft
AuthRoot set and the resulting signed PE chain verified successfully.