Skip to content

fix: set pwsh dvc exec capabilities flag only when pwsh is present#1867

Open
Vladyslav Nikonov (vnikonov-devolutions) wants to merge 1 commit into
masterfrom
fix/pwsh-availability-detection
Open

fix: set pwsh dvc exec capabilities flag only when pwsh is present#1867
Vladyslav Nikonov (vnikonov-devolutions) wants to merge 1 commit into
masterfrom
fix/pwsh-availability-detection

Conversation

@vnikonov-devolutions

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Conditionally advertises and executes PowerShell 7 DVC support based on executable discovery.

Changes:

  • Detects pwsh.exe at DVC startup.
  • Gates capabilities and execution using the resolved path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +314 to +317
std::env::split_paths(&path_var)
.filter(|dir| !dir.as_os_str().is_empty())
.map(|dir| dir.join("pwsh.exe"))
.find(|candidate| candidate.is_file())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants