Keep the app alive when the tray menu closes on a daemon launch (#5407) - #5431
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoSep 22, 2026
Merged
Conversation
3 tasks
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
September 22, 2026 15:58
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused lifecycle change fixes the daemon tray behavior while preserving existing explicit quit handling.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures daemon-launched instances remain alive after the tray menu closes by requiring explicit application shutdown.
Changes:
- Sets Avalonia’s shutdown mode to
OnExplicitShutdown. - Imports the required
Avalonia.Controlsnamespace.
| File | Description |
|---|---|
src/UniGetUI.Avalonia/App.axaml.cs |
Configures explicit shutdown before creating the main window. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![randy-but-a-ro[bot]](https://avatars.githubusercontent.com/in/113084?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "aee44700-b69e-11f1-9045-1a2460a0838e",
"headSha": "708deb9c9837bc4188d088f5a9d84b24d6039612",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/daemon-tray-menu-shutdown-5407
branch
September 22, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor update to the application startup logic by explicitly setting the shutdown mode for the desktop application. This change ensures more controlled application shutdown behavior.
Application lifecycle management:
desktop.ShutdownModetoShutdownMode.OnExplicitShutdownin theCreateAndShowMainWindowmethod to require explicit shutdown, improving control over application exit.Dependency management:
using Avalonia.Controls;directive to support the use ofShutdownMode.