Fix notification functionality in Avalonia#4864
Open
Gabriel Dufresne (GabrielDuf) wants to merge 1 commit into
Open
Fix notification functionality in Avalonia#4864Gabriel Dufresne (GabrielDuf) wants to merge 1 commit into
Gabriel Dufresne (GabrielDuf) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System (toast) notifications never appeared in the Avalonia app, while they work in the WinUI build. This wires the Windows App SDK into the Avalonia project and fixes the reflection bridge so toasts fire for the same events WinUI covers. #4861
Changes
Microsoft.WindowsAppSDK1.7 (Windows-only), mirroring WinUI's unpackaged/self-contained setup; addBuiltInComInteropSupport=true(needed for WinRT activation),EnableCoreMrtTooling=false(drops the VS-only MSIX/PRI tooling that broke CLI builds), and suppress theMVVMTK0045CsWinRT false-positive.Register()overload; subscribe toNotificationInvokedbeforeRegister(); and resolve builder overloads (e.g.AddText) by argument type.Coverage
Achieves parity with WinUI — operation progress/success/error, updates-available, upgrading-packages, self-update-available, and new-desktop-shortcuts notifications, plus toast click/button actions. Windows uses the App SDK bridge; macOS uses the existing osascript bridge; Linux falls back to the in-app banner (unchanged).