[jules] style: Consistent hover/focus states across all buttons#318
[jules] style: Consistent hover/focus states across all buttons#318
Conversation
Adds `focus-visible` states to Button, Input password toggle, Modal close, and Toast close buttons. This ensures consistent keyboard accessibility focus rings across both Glassmorphism and Neobrutalism themes. Updates .Jules tracking files. Co-authored-by: Devasy23 <110348311+Devasy23@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for split-but-wiser ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThe PR adds keyboard accessibility improvements by implementing consistent Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage ? 63.55%
=======================================
Files ? 21
Lines ? 2456
Branches ? 254
=======================================
Hits ? 1561
Misses ? 831
Partials ? 64
🚀 New features to boost your workflow:
|
This commit implements consistent hover and
focus-visiblestates across the primary interactive UI components in the web application.By applying tailored tailwind classes, it ensures that keyboard navigation provides clear, visible focus rings in both the Neobrutalism and Glassmorphism themes, without interrupting the visual aesthetic for mouse users.
Modified components include:
Button.tsx: Addedfocus-visibleoutlines and offsets handling both themes and dark modes.Input.tsx: Updated the password visibility toggle icon to have consistentfocus-visiblestyling instead of genericfocus.Modal.tsx: Updated the top-right close icon with a proper focus ring.Toast.tsx: Updated the dismiss icon to support keyboard focus visibility.Tracking files (
.Jules/todo.mdand.Jules/changelog.md) have also been updated to reflect this completion.PR created automatically by Jules for task 2744296281194979898 started by @Devasy23
Summary by CodeRabbit