Fix: TypeError Invalid URL error in prepareBaseUrl#8470
Merged
Bayheck merged 5 commits intoDevExpress:masterfrom Dec 29, 2025
Merged
Fix: TypeError Invalid URL error in prepareBaseUrl#8470Bayheck merged 5 commits intoDevExpress:masterfrom
Bayheck merged 5 commits intoDevExpress:masterfrom
Conversation
testcafe-need-response-bot
Bot
added
the
STATE: Need response
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the prepareBaseUrl function in src/api/test-page-url.ts to handle different URL types (HTTP/HTTPS, file URLs, and filesystem paths) with explicit branching logic instead of the previous approach that used path.join and conditional logic.
Key changes:
- Explicit handling for HTTP/HTTPS URLs with trailing slash normalization
- Dedicated handling for file:// URLs
- Improved handling of filesystem paths (both absolute and relative)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bayheck
removed
the
STATE: Need response
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aleks-pro
approved these changes
Dec 29, 2025
Bayheck
changed the title
|
Release v3.7.4 addresses this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
closes #8434
closes #8364
Pre-Merge TODO