Skip to content

Node.js: commit the latest version#8738

Open
pharret31 wants to merge 5 commits into
26_1from
4091-update-node-version-in-repos
Open

Node.js: commit the latest version#8738
pharret31 wants to merge 5 commits into
26_1from
4091-update-node-version-in-repos

Conversation

@pharret31
Copy link
Copy Markdown

No description provided.

@pharret31 pharret31 self-assigned this May 7, 2026
Copilot AI review requested due to automatic review settings May 7, 2026 15:39
@pharret31 pharret31 added the 26_1 label May 7, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the repository’s Node.js version across local developer tooling and CI by pinning Node 24.15.0 and enforcing engine checks.

Changes:

  • Added Node.js version pinning to package.json (engines, volta) and new version files (.node-version, .tool-versions).
  • Enforced Node engine compatibility via .npmrc (engine-strict=true).
  • Updated the shared GitHub composite action to read the Node version from .node-version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Pins Node version via engines and Volta configuration.
.tool-versions Adds asdf Node.js version pin.
.npmrc Enforces Node engine checks during installs.
.node-version Adds a single source of truth for Node version pinning.
.github/actions/setup-env/action.yml Switches CI Node setup to use .node-version.

Comment thread package.json Outdated
Comment thread .github/actions/setup-env/action.yml
Copilot AI review requested due to automatic review settings May 8, 2026 11:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/actions/setup-env/action.yml:21

  • inputs.path is optional, but it is interpolated as ${{ inputs.path }}/…. When the caller does not pass path (for example in .github/workflows/nodejs.yml), this resolves to /.node-version and /package.json (absolute paths) and will cause the action to fail to find these files. Set a default for inputs.path (for example .) and/or build the paths using an expression fallback (for example ${{ inputs.path || '.' }}) so the root workflow continues to work.
    - name: Setup Node.js
      uses: actions/setup-node@v4
      with:
        node-version-file: ${{ inputs.path }}/.node-version

    - uses: pnpm/action-setup@v4
      with:
        run_install: false
        package_json_file: ${{ inputs.path }}/package.json

Comment thread package.json Outdated
Comment thread .github/actions/setup-env/action.yml
Copilot AI review requested due to automatic review settings May 13, 2026 09:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment on lines 12 to 16
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version-file: ${{ inputs.path }}/.node-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants