Node.js: commit the latest version#8738
Open
pharret31 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the repository’s Node.js version across local developer tooling and CI by pinning Node 24.15.0 and enforcing engine checks.
Changes:
- Added Node.js version pinning to
package.json(engines,volta) and new version files (.node-version,.tool-versions). - Enforced Node engine compatibility via
.npmrc(engine-strict=true). - Updated the shared GitHub composite action to read the Node version from
.node-version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Pins Node version via engines and Volta configuration. |
| .tool-versions | Adds asdf Node.js version pin. |
| .npmrc | Enforces Node engine checks during installs. |
| .node-version | Adds a single source of truth for Node version pinning. |
| .github/actions/setup-env/action.yml | Switches CI Node setup to use .node-version. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/actions/setup-env/action.yml:21
inputs.pathis optional, but it is interpolated as${{ inputs.path }}/…. When the caller does not passpath(for example in.github/workflows/nodejs.yml), this resolves to/.node-versionand/package.json(absolute paths) and will cause the action to fail to find these files. Set a default forinputs.path(for example.) and/or build the paths using an expression fallback (for example${{ inputs.path || '.' }}) so the root workflow continues to work.
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: ${{ inputs.path }}/.node-version
- uses: pnpm/action-setup@v4
with:
run_install: false
package_json_file: ${{ inputs.path }}/package.json
dmlvr
requested changes
May 8, 2026
dmlvr
approved these changes
May 8, 2026
Comment on lines
12
to
16
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
| node-version-file: ${{ inputs.path }}/.node-version | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.