Grids: Move adaptivity extenders to separate files - #34857
Open
Alyar666 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the grid adaptivity subsystem by extracting adaptivity extenders/constants/module registration into dedicated files and updating internal controller property names/usages across DataGrid/TreeList grid-core code.
Changes:
- Split
grid_core/adaptivityextenders (rowsView, resizing, keyboard navigation, editing, data controller, etc.) into separate files and introduced a dedicatedadaptivity_module.ts. - Updated multiple controllers/views to use
adaptiveColumnsController(instead of_adaptiveColumnsController) and updated the DataGrid QUnit test accordingly. - Rewired DataGrid/TreeList module registration to import the new adaptivity module entry points.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/adaptiveColumns.tests.js | Updates test to use rowsView.adaptiveColumnsController after controller property rename. |
| packages/devextreme/js/__internal/grids/tree_list/module_not_extended/adaptivity.ts | Switches TreeList module import to the new adaptivity_module entry point. |
| packages/devextreme/js/__internal/grids/grid_core/views/m_grid_view.ts | Renames/resets resizing controller field to adaptiveColumnsController. |
| packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts | Renames/resets columns view field to adaptiveColumnsController. |
| packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts | Updates sticky-columns logic to use adaptiveColumnsController. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts | Updates keyboard navigation controller field name and usage. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts | Updates editing controller field name and initialization. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Removes unused _adaptiveColumnsController reference from DataController. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/m_adaptivity.ts | Moves constants/extenders out and updates adaptive-expanded-key API usage. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_rows_view.ts | New: rows view adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_resizing_controller.ts | New: resizing controller adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_keyboard_navigation.ts | New: keyboard navigation adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_headers_keyboard_navigation.ts | New: headers keyboard navigation adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_editor_factory.ts | New: editor factory adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_editing.ts | New: editing adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_dragging_header.ts | New: dragging header adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_data_controller.ts | New: data controller adaptivity extender extracted into its own file (needs fixes for adaptive-expanded-key API). |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_columns.ts | New: columns controller adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/extenders/adaptivity_columns_resizer.ts | New: columns resizer adaptivity extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/const.ts | Promotes adaptivity constants into a shared const.ts. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/adaptivity_module.ts | New: shared grid-core adaptivity module definition. |
| packages/devextreme/js/__internal/grids/data_grid/module_not_extended/adaptivity.ts | Removed: DataGrid module registration moved to a new entry point. |
| packages/devextreme/js/__internal/grids/data_grid/m_widget.ts | Updates DataGrid widget wiring to import the new adaptivity module entry point. |
| packages/devextreme/js/__internal/grids/data_grid/adaptivity/extenders/adaptivity_export.ts | New: DataGrid-specific adaptivity export extender extracted into its own file. |
| packages/devextreme/js/__internal/grids/data_grid/adaptivity/adaptivity_module.ts | New: DataGrid adaptivity module registration that extends the grid-core adaptivity module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+81
to
+87
| private adaptiveExpandedKey(value) { | ||
| if (isDefined(value)) { | ||
| this._adaptiveExpandedKey = value; | ||
| } else { | ||
| return this._adaptiveExpandedKey; | ||
| } | ||
| } |
Comment on lines
+122
to
+125
| protected _beforeCloseEditCellInBatchMode(rowIndices) { | ||
| // @ts-expect-error | ||
| const expandedKey = this._dataController.adaptiveExpandedKey; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.