SCSS: use adjust if not achromatic helper for all color.adjust#34218
Open
vorobey wants to merge 2 commits into
Open
SCSS: use adjust if not achromatic helper for all color.adjust#34218vorobey wants to merge 2 commits into
vorobey wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DevExtreme SCSS theme color calculations to route hue/saturation/lightness adjustments through the existing adjust-if-not-achromatic helper, avoiding hue adjustments on achromatic colors (and keeping adjustments consistently in HSL space) across Material/Generic/Fluent widget palettes.
Changes:
- Replaced
sass:color.adjust(..., $hue: ..., $space: hsl, ...)usages withextcolor.adjust-if-not-achromatic(...)in multiple widget_colors.scssfiles. - Added
@use "../color" as extcolor;(or./color) imports where needed to access the helper. - Updated several Fluent base/derived accent and danger state variables to use the helper for hue-based adjustments.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme-scss/scss/widgets/material/loadIndicator/_colors.scss | Uses extcolor.adjust-if-not-achromatic for sparkle background variants that adjust hue. |
| packages/devextreme-scss/scss/widgets/material/informer/_colors.scss | Switches informer background adjustments to adjust-if-not-achromatic. |
| packages/devextreme-scss/scss/widgets/material/cardView/_colors.scss | Routes prohibition icon color adjustment through the helper. |
| packages/devextreme-scss/scss/widgets/generic/loadIndicator/_colors.scss | Uses helper for sparkle color variants that adjust hue. |
| packages/devextreme-scss/scss/widgets/generic/informer/_colors.scss | Uses helper for hue-based error/info colors across schemes. |
| packages/devextreme-scss/scss/widgets/generic/cardView/_colors.scss | Uses helper for selected/dropzone accent adjustments that include hue. |
| packages/devextreme-scss/scss/widgets/fluent/scheduler/_colors.scss | Uses helper for hue-based focused cell color in SaaS scheme. |
| packages/devextreme-scss/scss/widgets/fluent/loadIndicator/_colors.scss | Uses helper for hue-based segment border and sparkle colors. |
| packages/devextreme-scss/scss/widgets/fluent/informer/_colors.scss | Uses helper for hue-based error background in light mode. |
| packages/devextreme-scss/scss/widgets/fluent/gridBase/_colors.scss | Uses helper for hue-based focused row background (incl. a no-op saturation argument). |
| packages/devextreme-scss/scss/widgets/fluent/chat/_colors.scss | Uses helper for hue-based primary bubble colors in light/dark. |
| packages/devextreme-scss/scss/widgets/fluent/cardView/_colors.scss | Uses helper for selected/drag/dropzone hue-based accent/danger adjustments. |
| packages/devextreme-scss/scss/widgets/fluent/calendar/_colors.scss | Uses helper for hue-based hover background in dark mode. |
| packages/devextreme-scss/scss/widgets/fluent/button/_colors.scss | Uses helper for hue-based accent/outlined state colors. |
| packages/devextreme-scss/scss/widgets/fluent/badge/_colors.scss | Uses helper for hue-based badge background in dark mode. |
| packages/devextreme-scss/scss/widgets/fluent/_colors.scss | Uses helper for base accent/danger active/selected hue-based adjustments. |
sjbur
previously approved these changes
Jul 7, 2026
pharret31
reviewed
Jul 7, 2026
pharret31
left a comment
pharret31
left a comment
Contributor
There was a problem hiding this comment.
Consider removing unused imports as copilot suggests
GoodDayForSurf
approved these changes
Jul 7, 2026
ajivanyandev
approved these changes
Jul 7, 2026
Alyar666
approved these changes
Jul 8, 2026
pharret31
approved these changes
Jul 8, 2026
aleksei-semikozov
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.