CI: make visual test passing rules stricter#34177
Merged
EugeniyKiyashko merged 19 commits intoJul 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens CI visual/E2E TestCafe “pass” criteria by disabling automatic recovery mechanisms (quarantine/retries) and explicitly marking a couple of flaky tests as unstable.
Changes:
- Disabled TestCafe quarantine mode in the visual-tests GitHub workflow jobs.
- Disabled failed-test retries in the
e2e/testcafe-devextremerunner. - Marked specific Scheduler/DateRangeBox tests as
unstableand adjusted one fixture’s page-reload behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| e2e/testcafe-devextreme/tests/scheduler/common/dragAndDrop/appointmentCollector.ts | Marks a flaky drag-and-drop test as unstable. |
| e2e/testcafe-devextreme/tests/editors/dateRangeBox/keyboard.ts | Enables page reloads for the fixture and marks a flaky tab-navigation test as unstable. |
| e2e/testcafe-devextreme/runner.ts | Disables failed-test retries and simplifies retry logic. |
| .github/workflows/visual-tests-demos.yml | Attempts to disable TestCafe quarantine mode in CI runs. |
EugeniyKiyashko
force-pushed
the
26_1_tests_stability
branch
from
88bf802 to
c2c331b
Compare
EugeniyKiyashko
force-pushed
the
26_1_tests_stability
branch
2 times, most recently
from
1c093b7 to
291788c
Compare
EugeniyKiyashko
force-pushed
the
26_1_tests_stability
branch
2 times, most recently
from
806ec34 to
994e010
Compare
EugeniyKiyashko
force-pushed
the
26_1_tests_stability
branch
from
994e010 to
8a5bd99
Compare
…shko/DevExtreme into 26_1_tests_stability
pharret31
previously approved these changes
Jul 7, 2026
pharret31
previously approved these changes
Jul 7, 2026
EugeniyKiyashko
force-pushed
the
26_1_tests_stability
branch
from
a93e034 to
0ddcd7d
Compare
alexslavr
approved these changes
Jul 8, 2026
pharret31
approved these changes
Jul 8, 2026
Comment on lines
313
to
317
| // Retry failed tests multiple times if enabled and there are failures | ||
| if (args.retryFailed && failedTests.size > 0 && failedCount > 0) { | ||
| const initialFailedCount = failedTests.size; | ||
| const noRetryFolders = ['cardView', 'dataGrid', 'common']; | ||
| let attemptsLeft = noRetryFolders.some((folder) => componentFolderArg === folder || componentFolderArg.startsWith(`${folder}/`)) | ||
| ? 0 | ||
| : FAILED_TESTS_RETRY_ATTEMPTS; | ||
| let attemptsLeft = FAILED_TESTS_RETRY_ATTEMPTS; | ||
|
|
Comment on lines
93
to
95
| .run({ | ||
| quarantineMode: getQuarantineMode(), | ||
| quarantineMode: { successThreshold: 1, attemptLimit: 2 }, | ||
| // @ts-expect-error ts-error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.