Skip to content

WIP. Use global config for separate locale format for Date and Number #34171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GoodDayForSurf wants to merge 11 commits into
base: 26_1
Choose a base branch
from
Draft

WIP. Use global config for separate locale format for Date and Number #34171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5fbf72b
Add tests
GoodDayForSurf Jul 2, 2026
dd63e5f
Add tests
GoodDayForSurf Jul 3, 2026
b4400e1
implementation
GoodDayForSurf Jul 3, 2026
3f94a81
fix tests
GoodDayForSurf Jul 3, 2026
d51145e
use global config numberFormat.locale for mask
GoodDayForSurf Jul 3, 2026
44d3ef4
fix TS types
GoodDayForSurf Jul 4, 2026
e370a6c
fix scheduler test
GoodDayForSurf Jul 4, 2026
171b78b
Merge branch '26_1' into 26_1_split_locale_format
GoodDayForSurf Jul 4, 2026
c226255
regenerate dx.all.d.ts
GoodDayForSurf Jul 4, 2026
852e0c7
Merge branch '26_1_split_locale_format' of https://github.com/GoodDay…
GoodDayForSurf Jul 4, 2026
9bf8d9f
regenerate wrappers
GoodDayForSurf Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/devextreme-angular/src/common/core/localization/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ export {
} from 'devextreme/common/core/localization';
export type {
Format,
FormatLocale,
} from 'devextreme/common/core/localization';
1 change: 1 addition & 0 deletions packages/devextreme-angular/src/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ export namespace Core {
export namespace Localization {
export type Format = CoreLocalizationModule.Format;
export const formatDate = CoreLocalizationModule.formatDate;
export type FormatLocale = CoreLocalizationModule.FormatLocale;
export const formatMessage = CoreLocalizationModule.formatMessage;
export const formatNumber = CoreLocalizationModule.formatNumber;
export const loadMessages = CoreLocalizationModule.loadMessages;
Expand Down
1 change: 1 addition & 0 deletions packages/devextreme-angular/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ export namespace Common {
export namespace Localization {
export type Format = import('devextreme/common/core/localization').Format;
export const formatDate = (CoreLocalizationModule as any).formatDate as typeof import('devextreme/common/core/localization').formatDate;
export type FormatLocale = import('devextreme/common/core/localization').FormatLocale;
export const formatMessage = (CoreLocalizationModule as any).formatMessage as typeof import('devextreme/common/core/localization').formatMessage;
export const formatNumber = (CoreLocalizationModule as any).formatNumber as typeof import('devextreme/common/core/localization').formatNumber;
export const loadMessages = (CoreLocalizationModule as any).loadMessages as typeof import('devextreme/common/core/localization').loadMessages;
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/bar-gauge/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoBarGaugeFormatComponent extends NestedOption implements OnDestro
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/bar-gauge/nested/item-text-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoBarGaugeItemTextFormatComponent extends NestedOption implements
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/bullet/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoBulletFormatComponent extends NestedOption implements OnDestroy,
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/card-view/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoCardViewFormatComponent extends NestedOption implements OnDestro
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/chart/nested/argument-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoChartArgumentFormatComponent extends NestedOption implements OnD
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/chart/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoChartFormatComponent extends NestedOption implements OnDestroy,
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/chat/nested/day-header-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoChatDayHeaderFormatComponent extends NestedOption implements OnD
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/chat/nested/message-timestamp-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoChatMessageTimestampFormatComponent extends NestedOption impleme
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/circular-gauge/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoCircularGaugeFormatComponent extends NestedOption implements OnD
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/data-grid/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoDataGridFormatComponent extends NestedOption implements OnDestro
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/data-grid/nested/value-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoDataGridValueFormatComponent extends NestedOption implements OnD
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/date-box/nested/display-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoDateBoxDisplayFormatComponent extends NestedOption implements On
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/date-range-box/nested/display-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoDateRangeBoxDisplayFormatComponent extends NestedOption implemen
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/filter-builder/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoFilterBuilderFormatComponent extends NestedOption implements OnD
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/funnel/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoFunnelFormatComponent extends NestedOption implements OnDestroy,
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
9 changes: 9 additions & 0 deletions packages/devextreme-angular/src/ui/gantt/nested/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {



import type { FormatLocale } from 'devextreme/common/core/localization';
import type { Format } from 'devextreme/common';

import {
Expand Down Expand Up @@ -47,6 +48,14 @@ export class DxoGanttFormatComponent extends NestedOption implements OnDestroy,
this._setOption('formatter', value);
}

@Input()
get locale(): FormatLocale {
return this._getOption('locale');
}
set locale(value: FormatLocale) {
this._setOption('locale', value);
}

@Input()
get parser(): ((value: string) => number | Date) {
return this._getOption('parser');
Expand Down
Loading
Loading