AI Assistant: AI uses "or" filter operation instead of "anyof" - so there is no sync with HeaderFilter#33872
Open
Raushen wants to merge 4 commits into
Open
Conversation
…AIAssistant-Anyof-Filter-Operarion
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Grid AI Assistant’s filterValue command and related public typings to support multi-value filtering via anyof/noneof, aligning AI-generated filters with HeaderFilter/filterSync behavior.
Changes:
- Added public typings for multi-value filter expressions (
MultiValueFilterExpr) and scalar filter values (FilterScalarValue), plusMultiValueSearchOperation(anyof/noneof) across core and wrappers. - Extended AI Assistant filter schema + conversion to accept multi-value expressions and resolve date strings within
anyof/noneofarrays. - Improved filter success message generation by passing custom filter operations to
filterPanelView.getFilterText, and added/updated unit tests.
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Mirrors new public types/aliases in the bundled TS declarations (multi-value operation + multi-value filter expr). |
| packages/devextreme/js/common/grids.d.ts | Introduces FilterScalarValue + MultiValueFilterExpr and extends FilterExpr to include multi-value filtering. |
| packages/devextreme/js/common/data.types.d.ts | Adds MultiValueSearchOperation (anyof/noneof) to shared data operation types. |
| packages/devextreme/js/common/data.d.ts | Re-exports MultiValueSearchOperation under DevExpress.common.data. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/utils.ts | Reuses the new scalar type and adds a helper guard for multi-value expressions. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts | Accepts multi-value filter expressions in Zod schema, converts them to legacy filter arrays, and uses custom operations for filter text. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/utils.test.ts | Adds tests for isMultiValueExpr. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/filtering.test.ts | Adds schema + execution tests covering anyof/noneof, including date resolution inside arrays. |
| packages/devextreme-vue/src/common/index.ts | Re-exports new types in Vue wrapper namespaces. |
| packages/devextreme-vue/src/common/grids.ts | Re-exports FilterScalarValue/MultiValueFilterExpr from Vue grids typings. |
| packages/devextreme-vue/src/common/data.ts | Re-exports MultiValueSearchOperation from Vue data typings. |
| packages/devextreme-react/src/common/index.ts | Re-exports new types in React wrapper namespaces. |
| packages/devextreme-react/src/common/grids.ts | Re-exports FilterScalarValue/MultiValueFilterExpr from React grids typings. |
| packages/devextreme-react/src/common/data.ts | Re-exports MultiValueSearchOperation from React data typings. |
| packages/devextreme-angular/src/index.ts | Re-exports MultiValueSearchOperation via Angular root namespace. |
| packages/devextreme-angular/src/common/index.ts | Re-exports new types in Angular wrapper namespaces. |
| packages/devextreme-angular/src/common/grids/index.ts | Re-exports FilterScalarValue/MultiValueFilterExpr from Angular grids typings. |
| packages/devextreme-angular/src/common/data/index.ts | Re-exports MultiValueSearchOperation from Angular data typings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.