Skip to content

DataGrid: Fix detail grid reloading data when collapsed master row reenters viewport with virtual row rendering (T1326188)#33224

Open
Alyar666 wants to merge 2 commits intoDevExpress:26_1from
Alyar666:T1326188_26_1
Open

DataGrid: Fix detail grid reloading data when collapsed master row reenters viewport with virtual row rendering (T1326188)#33224
Alyar666 wants to merge 2 commits intoDevExpress:26_1from
Alyar666:T1326188_26_1

Conversation

@Alyar666
Copy link
Copy Markdown
Contributor

No description provided.

@Alyar666 Alyar666 self-assigned this Apr 10, 2026
@Alyar666 Alyar666 requested a review from a team as a code owner April 10, 2026 10:38
Copilot AI review requested due to automatic review settings April 10, 2026 10:38
@Alyar666 Alyar666 added the 26_1 label Apr 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an issue where a DataGrid’s master-detail content could be re-created (and the detail grid’s data reloaded) when a collapsed master row re-enters the viewport under virtual row rendering.

Changes:

  • Clear DataController’s processed-items cache after toggling master row expand/collapse state to prevent stale processed rows from being reused during subsequent viewport refreshes.
  • Add a new TestCafe functional test covering the regression scenario (standard scrolling + rowRenderingMode: 'virtual').
  • Fix TestCafe masterDetail visual test helper imports and correct the container page path.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/devextreme/js/__internal/grids/grid_core/master_detail/m_master_detail.ts Clears processed-items cache after row expand/collapse to avoid stale master-detail row processing during viewport refresh.
packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts Adds a small helper to reset _cachedProcessedItems.
e2e/testcafe-devextreme/tests/dataGrid/common/masterDetail/visual.ts Fixes helper import paths and corrects the relative container.html path for the fixture.
e2e/testcafe-devextreme/tests/dataGrid/common/masterDetail/functional.ts Adds a regression test ensuring the detail grid does not reload when a collapsed master row re-enters the viewport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants