Scheduler - Fix unstable tests - QUnit - integration.dstAppointments.tests.js

[aleksei-semikozov]

No description provided.

[Copilot]

Pull request overview

This PR fixes unstable QUnit tests for DST (Daylight Saving Time) appointments in the Scheduler component by unskipping previously skipped test modules and updating them with proper test patterns to ensure stability.

Changes:

• Unskipped two test modules by changing QUnit.skip to QUnit.module
• Added legacyForm: true configuration to tests that verify appointment form behavior
• Implemented fake timer pattern for appointment clicks to prevent timing issues
• Removed several tests that checked appointment rendering positions (likely unstable)
• Updated assertions to expect appointment timezone times instead of converted scheduler timezone times (matching legacyForm behavior)
• Removed unused timeZoneUtils import
• Removed one complete test about recurrence exception deletion behavior

Comments suppressed due to low confidence (1)

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.dstAppointments.tests.js:360

• The assertion message 'Appointment was deleted' is misleading. This test verifies that a recurrence exception is not rendered after timezone adjustment, not that an appointment was deleted. The test doesn't perform any delete action. Consider changing the message to something like 'exception is not rendered' or 'correct number of events after timezone change' to accurately reflect what the test is verifying.

        assert.equal(scheduler.appointments.getAppointmentCount(), 0, 'Appointment was deleted');

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.dstAppointments.tests.js:35

• Stubbing Date.prototype.getTimezoneOffset in the module hook is a very broad change that can impact unrelated Date logic inside the Scheduler, Sinon fake timers, and other helpers. In this codebase, timezone-dependent tests typically stub timeZoneUtils.getClientTimezoneOffset (and/or other timeZoneUtils helpers) instead of modifying Date.prototype directly (e.g. testing/tests/DevExpress.ui.widgets.scheduler/timezones.tests.js stubs getClientTimezoneOffset). Consider replacing the Date.prototype stub with a timeZoneUtils.getClientTimezoneOffset stub (or limiting the stub to the specific helper under test) to reduce side effects and keep the approach consistent with existing tests.

        this.tzStub = sinon.stub(timeZoneUtils, 'getDiffBetweenClientTimezoneOffsets').returns(0);

        // Stub getTimezoneOffset to return 0 (UTC) to avoid CI timezone affecting Date operations
        this.timezoneOffsetStub = sinon.stub(Date.prototype, 'getTimezoneOffset').returns(0);
    },

packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/integration.dstAppointments.tests.js:382

• The final assertion message is misleading here: the test verifies that no occurrences are rendered due to recurrenceException, but the message says "Appointment was deleted". Updating the assertion text to describe the expected behavior (no appointment rendered because the occurrence is excluded) will make failures easier to diagnose.

        assert.equal(scheduler.appointments.getAppointmentCount(), 0, 'Appointment was deleted');